ddanielr commented on code in PR #384: URL: https://github.com/apache/accumulo-website/pull/384#discussion_r1175893463
########## build-images.sh: ########## Review Comment: I moved the `build-images.sh` script into `_scripts` and swapped to the `env` line. `shellcheck` looks to not be an easy install on centos, but I added shfmt via `go install` and formatted the script against your command. Unfortunately, I don't think we can move the Dockerfile out from the root directory location. When docker builds an image, the current directory of the Dockerfile is passed as the build context to the docker daemon. This restricts directory transversal and file references above the build context do not work. Since the Gemfile and Gemfile.lock are needed by the build operation, the Dockerfile has to exist at the same directory level or higher. Ruby wants the Gemfile at the project's root so I think that's at an impasse. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
