EdColeman commented on code in PR #3361:
URL: https://github.com/apache/accumulo/pull/3361#discussion_r1180486199
##########
server/manager/src/main/java/org/apache/accumulo/manager/state/SetGoalState.java:
##########
@@ -45,12 +44,12 @@ public static void main(String[] args) throws Exception {
try {
var siteConfig = SiteConfiguration.auto();
SecurityUtil.serverLogin(siteConfig);
- var context = new ServerContext(siteConfig);
- RenameMasterDirInZK.renameMasterDirInZK(context);
- context.waitForZookeeperAndHdfs();
- context.getZooReaderWriter().putPersistentData(
- context.getZooKeeperRoot() + Constants.ZMANAGER_GOAL_STATE,
args[0].getBytes(UTF_8),
- NodeExistsPolicy.OVERWRITE);
+ try (var context = new ServerContext(siteConfig)) {
Review Comment:
Basically - calling close on the server context in the manager seem that it
could be unintentional / unsafe if the context was being used elsewhere - it
would take someone looking at the code additional time to figure that out and a
simple comment might save someone same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
