EdColeman commented on code in PR #3361:
URL: https://github.com/apache/accumulo/pull/3361#discussion_r1180487788
##########
server/manager/src/main/java/org/apache/accumulo/manager/state/SetGoalState.java:
##########
@@ -45,12 +44,12 @@ public static void main(String[] args) throws Exception {
try {
var siteConfig = SiteConfiguration.auto();
SecurityUtil.serverLogin(siteConfig);
- var context = new ServerContext(siteConfig);
- RenameMasterDirInZK.renameMasterDirInZK(context);
- context.waitForZookeeperAndHdfs();
- context.getZooReaderWriter().putPersistentData(
- context.getZooKeeperRoot() + Constants.ZMANAGER_GOAL_STATE,
args[0].getBytes(UTF_8),
- NodeExistsPolicy.OVERWRITE);
+ try (var context = new ServerContext(siteConfig)) {
Review Comment:
Its not a big issue - just something that I thought may help. But if you
you feel otherwise, that's fine too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
