DomGarguilo commented on code in PR #3342:
URL: https://github.com/apache/accumulo/pull/3342#discussion_r1180668051
##########
core/src/main/java/org/apache/accumulo/core/data/RowRange.java:
##########
@@ -45,8 +45,91 @@ public RowRange() {
* @param endRow ending row; set to null for positive infinity
* @throws IllegalArgumentException if end row is before start row
*/
- public RowRange(Text startRow, Text endRow) {
- this(startRow, true, endRow, true);
+ public static RowRange open(Text startRow, Text endRow) {
+ return create(startRow, true, endRow, true);
+ }
+
+ /**
+ * Creates a range of rows from startRow exclusive to endRow exclusive.
+ *
+ * @param startRow starting row; set to null for the smallest possible row
(an empty one)
+ * @param endRow ending row; set to null for positive infinity
+ * @throws IllegalArgumentException if end row is before start row
+ */
+ public static RowRange closed(Text startRow, Text endRow) {
+ return create(startRow, false, endRow, false);
+ }
Review Comment:
Addressed in a527552 but please double check I got things correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
