keith-turner commented on code in PR #3342: URL: https://github.com/apache/accumulo/pull/3342#discussion_r1185495088
########## core/src/main/java/org/apache/accumulo/core/data/RowRange.java: ########## @@ -0,0 +1,641 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.core.data; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.Collections; +import java.util.Comparator; +import java.util.List; +import java.util.Objects; + +import org.apache.hadoop.io.BinaryComparable; +import org.apache.hadoop.io.Text; + +/** + * This class is used to specify a range of rows. + * + * @since 3.0.0 + */ +public class RowRange implements Comparable<RowRange> { + + private static final Comparator<Text> START_ROW_COMPARATOR = + Comparator.nullsFirst(Text::compareTo); + private static final Comparator<Text> END_ROW_COMPARATOR = Comparator.nullsLast(Text::compareTo); + public static final Comparator<RowRange> ROW_RANGE_COMPARATOR = (r1, r2) -> { + if (r1.startRow == null && r2.startRow == null) { + return 0; + } else if (r1.startRow == null) { + return -1; + } else if (r2.startRow == null) { + return 1; + } + return r1.compareTo(r2); Review Comment: Looking at this comparison I see how it differs. It compares the start row for null, then if those are both non-null it compares the entire range. I missed that at the end, I thought it was consistently comparing the start row throughout. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
