keith-turner commented on code in PR #3349:
URL: https://github.com/apache/accumulo/pull/3349#discussion_r1181926800
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/ScanServer.java:
##########
@@ -149,8 +149,8 @@ private TabletMetadataLoader(Ample ample) {
loadAll(Set<? extends KeyExtent> keys) {
long t1 = System.currentTimeMillis();
@SuppressWarnings("unchecked")
- var tms = ample.readTablets().forTablets((Collection<KeyExtent>)
keys).build().stream()
- .collect(Collectors.toMap(tm -> tm.getExtent(), tm -> tm));
+ var tms = ample.readTablets().forTablets((Collection<KeyExtent>) keys, e
-> {}).build()
Review Comment:
I would like to to pass something that lets ample know they don't care
about the missing extents, because the implementation could then stream
directly from the scanner. When the caller wants to know what is missing ample
has to buffer everything. Thought about passing in an Optional<Consumer<>>,
then when a caller does not care they can pass in Optional.empty().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
