keith-turner commented on code in PR #3349:
URL: https://github.com/apache/accumulo/pull/3349#discussion_r1181998939
##########
server/compaction-coordinator/src/main/java/org/apache/accumulo/coordinator/CompactionFinalizer.java:
##########
@@ -155,7 +155,7 @@ private void processPending() {
Map<KeyExtent,TabletMetadata> tabletsMetadata;
var extents =
batch.stream().map(ExternalCompactionFinalState::getExtent).collect(toList());
- try (TabletsMetadata tablets =
context.getAmple().readTablets().forTablets(extents)
+ try (TabletsMetadata tablets =
context.getAmple().readTablets().forTablets(extents, e -> {})
Review Comment:
Since there can be a performance advantage when the consumer is not needed,
I think optional makes that intention very clear and the code can avoid trying
to compute the missing extents.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
