ctubbsii commented on code in PR #3336: URL: https://github.com/apache/accumulo/pull/3336#discussion_r1183216314
########## core/src/main/java/org/apache/accumulo/core/util/Nulls.java: ########## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.core.util; + +import java.util.function.Function; + +public class Nulls { + public static <T,R> R map(T object, Function<T,R> conversion) { + return object == null ? null : conversion.apply(object); + } Review Comment: I wouldn't use the Optional approach, but I'm pretty used to seeing the second option, and find it to be an acceptable level of boilerplate and risk. But, I'm also fine with the method. I still think it warrants a better name. I don't find the class name particularly helpful for explaining what the method does. If anything, it seems to imply that the method is mapping null values, not non-null ones, which is the exact opposite of what it's doing. Maybe if it was `NotNull.map()` or `NonNull.map()`, it would align to how it's being used here. But, I think the better method name would suffice, so that the `Nulls` class could be used for other convenient static methods as well. I also thought `Nulls.orElseMap(obj, mapper)` would be a good alternative name, but decided to only suggest my favorite of the two. It may also be useful to add a private constructor on `Null` to avoid anybody instantiating it, since it's just a utility class for static methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
