ctubbsii commented on code in PR #3336: URL: https://github.com/apache/accumulo/pull/3336#discussion_r1185934613
########## core/src/main/java/org/apache/accumulo/core/util/Nulls.java: ########## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.core.util; + +import java.util.function.Function; + +public class Nulls { + public static <T,R> R map(T object, Function<T,R> conversion) { + return object == null ? null : conversion.apply(object); + } Review Comment: > ...I only like it because its short... A static import could keep the line short. I also thought of `nullOrMap`, which has the same line length as your original, with the static import. The length of the class name doesn't even matter, then, and you could put the method in any utility class. I'm not always a fan of static imports, but I think there's a few cases where they really help with boilerplate utility code. This seems like it could be one of those cases. We do use the pattern in a lot of places, and having an error-resistant implementation for reuse somewhere might be helpful. Could be done as a separate PR for all of Accumulo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
