cshannon commented on code in PR #3385:
URL: https://github.com/apache/accumulo/pull/3385#discussion_r1189171569
##########
core/src/main/java/org/apache/accumulo/core/metadata/schema/ExternalCompactionMetadata.java:
##########
@@ -129,10 +129,11 @@ private static class GSonData {
public String toJson() {
GSonData jData = new GSonData();
- jData.inputs =
jobFiles.stream().map(StoredTabletFile::getMetaUpdateDelete).collect(toList());
- jData.nextFiles =
-
nextFiles.stream().map(StoredTabletFile::getMetaUpdateDelete).collect(toList());
- jData.tmp = compactTmpName.getMetaInsert();
+ jData.inputs = jobFiles.stream()
+ .map(tabletFile ->
tabletFile.getMetaUpdateDelete().getMetaString()).collect(toList());
+ jData.nextFiles = nextFiles.stream()
+ .map(tabletFile ->
tabletFile.getMetaUpdateDelete().getMetaString()).collect(toList());
Review Comment:
Same as other comment, we could update it to be the file reference but no
matter what it's going to still be a String value and will need to change in
the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
