cshannon commented on code in PR #3385:
URL: https://github.com/apache/accumulo/pull/3385#discussion_r1189174283
##########
core/src/main/java/org/apache/accumulo/core/metadata/StoredTabletFile.java:
##########
@@ -33,39 +35,47 @@
* in Upgrader9to10.upgradeRelativePaths()
*/
public class StoredTabletFile extends TabletFile {
- private final String metadataEntry;
+ private final TabletFileMetadataEntry metadataEntry;
Review Comment:
It's not quite the same, in TabletFile the value is actually generated and
created in the constructor and in StoredTabletFile is provided. It's a bit
weird with how everything was set up previously and I was trying to stay to the
existing pattern but it seems like there could be some refactoring work to be
done here as there does seems to be some duplication in some cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
