EdColeman commented on code in PR #3402:
URL: https://github.com/apache/accumulo/pull/3402#discussion_r1195554297
##########
core/src/main/java/org/apache/accumulo/core/conf/cluster/ClusterConfigParser.java:
##########
@@ -61,14 +61,12 @@ private static void flatten(String parentKey, String key,
Object value,
(parentKey == null || parentKey.equals("")) ? "" : parentKey +
addTheDot(parentKey);
if (value instanceof String) {
results.put(parent + key, (String) value);
- return;
Review Comment:
This may be easier to follow if the returns were kept, but the else clauses
removed. (more of a personnel preference?)
`if(string){
...
return
}
if(List) {
...
return
}
throw new IllegalStateException`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
