EdColeman commented on code in PR #3402:
URL: https://github.com/apache/accumulo/pull/3402#discussion_r1196747214
##########
core/src/main/java/org/apache/accumulo/core/conf/cluster/ClusterConfigParser.java:
##########
@@ -61,14 +61,12 @@ private static void flatten(String parentKey, String key,
Object value,
(parentKey == null || parentKey.equals("")) ? "" : parentKey +
addTheDot(parentKey);
if (value instanceof String) {
results.put(parent + key, (String) value);
- return;
Review Comment:
The nesting of the else clauses made it more difficult to examine your
changes to see that the behavior did not change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
