ctubbsii commented on code in PR #3402:
URL: https://github.com/apache/accumulo/pull/3402#discussion_r1196819154
##########
core/src/main/java/org/apache/accumulo/core/conf/cluster/ClusterConfigParser.java:
##########
@@ -61,14 +61,12 @@ private static void flatten(String parentKey, String key,
Object value,
(parentKey == null || parentKey.equals("")) ? "" : parentKey +
addTheDot(parentKey);
if (value instanceof String) {
results.put(parent + key, (String) value);
- return;
Review Comment:
I took another look, and I think it's fine the way it is. It seems like a
slight trade-off, mostly style preferences. I didn't write this code
originally, and don't have a stake in one style or the other... but I'm
inclined to keep the more minimal change in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
