ctubbsii commented on code in PR #3402:
URL: https://github.com/apache/accumulo/pull/3402#discussion_r1196823119
##########
core/src/main/java/org/apache/accumulo/core/rpc/ThriftUtil.java:
##########
@@ -398,7 +398,7 @@ private static void attemptClientReLogin() {
// The inability to check is worrisome and deserves a RuntimeException
instead of a propagated
// IO-like Exception.
log.warn("Failed to check (and/or perform) Kerberos client re-login", e);
- throw new RuntimeException(e);
+ throw new UncheckedIOException(e);
Review Comment:
Originally committed this, but reverted because this (or another one) broke
the formatter, and my change is more minimal. This might be an improvement, but
not one I'm inclined to bother with here. Maybe it'd be worth putting the
message in a String variable and reusing it, but that's out of scope of my
change, which is just using the more specific type.
##########
core/src/main/java/org/apache/accumulo/core/security/ColumnVisibility.java:
##########
@@ -151,7 +151,7 @@ public int getTermEnd() {
public ByteSequence getTerm(byte[] expression) {
if (type != NodeType.TERM) {
- throw new RuntimeException();
+ throw new IllegalStateException();
Review Comment:
Originally committed this, but reverted because this (or another one) broke
the formatter, and my change is more minimal. This might be an improvement, but
not one I'm inclined to bother with here. Maybe it'd be worth putting the
message in a String variable and reusing it, but that's out of scope of my
change, which is just using the more specific type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
