cshannon commented on PR #3417: URL: https://github.com/apache/accumulo/pull/3417#issuecomment-1565395333
> > > think this is fine but it would be nicer/more clear to rename the existing TabletFile to ReferencedTabletFile and create a TabletFile interface. > > > > > > @cshannon I like this, seems cleaner and feels like it will help improve code correctness. > > As mentioned I'll go ahead and rename this in another commit as I think it makes sense. By the way, I meant another PR, not commit. (I just noticed I said commit). I played around with renaming and it changes a ton of files (no surprise). So in order to keep the scope of the changes here easier to see and not pollute the PR, it would be better to do the renaming as a follow on PR once this is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
