dlmarion commented on code in PR #3479:
URL: https://github.com/apache/accumulo/pull/3479#discussion_r1224647379
##########
server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java:
##########
@@ -905,30 +902,20 @@ private void handleDeadTablets(TabletLists tLists,
WalStateManager wals)
private void getAssignmentsFromBalancer(TabletLists tLists,
Map<KeyExtent,UnassignedTablet> unassigned) {
- if (!tLists.currentTServers.isEmpty()) {
+ if (!tLists.validAssignmentDestinations.isEmpty()) {
Map<KeyExtent,TServerInstance> assignedOut = new HashMap<>();
- manager.getAssignments(tLists.currentTServers, unassigned, assignedOut);
+ manager.getAssignments(tLists.validAssignmentDestinations, unassigned,
assignedOut);
for (Entry<KeyExtent,TServerInstance> assignment :
assignedOut.entrySet()) {
if (unassigned.containsKey(assignment.getKey())) {
if (assignment.getValue() != null) {
- if (!tLists.currentTServers.containsKey(assignment.getValue())) {
+ if
(!tLists.validAssignmentDestinations.containsKey(assignment.getValue())) {
Manager.log.warn(
"balancer assigned {} to a tablet server that is not current
{} ignoring",
assignment.getKey(), assignment.getValue());
continue;
}
final UnassignedTablet unassignedTablet =
unassigned.get(assignment.getKey());
- final TServerInstance serverInstance =
- unassignedTablet != null ?
unassignedTablet.getServerInstance() : null;
- if (serverInstance != null
- &&
!assignment.getValue().getHostPort().equals(serverInstance.getHostPort())) {
- Manager.log.warn(
- "balancer assigned {} to {} which is not the suggested
location of {}",
- assignment.getKey(), assignment.getValue().getHostPort(),
- serverInstance.getHostPort());
- }
-
Review Comment:
@ivakegg @cshannon - you both recently added/touched the code block above
that is being removed. It prints a warning in the log if the tablet is not
assigned to it's last location. In the cases where the TabletServer is down, or
maybe even in a rebalance, then this will spam the log for every tablet that
was assigned to it. Is that desired?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
