cshannon commented on code in PR #3506:
URL: https://github.com/apache/accumulo/pull/3506#discussion_r1240728853
##########
server/base/src/main/java/org/apache/accumulo/server/constraints/MetadataConstraints.java:
##########
@@ -128,6 +129,23 @@ private static ArrayList<Short>
addIfNotPresent(ArrayList<Short> lst, int intVio
return lst;
}
+ /*
+ * Validates the data file metadata by creating a StoredTabletFile for the
metadata string that
+ * will eagerly load the contained ReferencedTabletFile which performs
validation.
+ *
+ * We have to catch a generic Exception as various errors can occur including
+ * NullPointerException, IllegalArgumentException, etc.
+ */
+ private static ArrayList<Short> validateDataFilePath(ArrayList<Short>
violations,
+ String metadata) {
+ try {
+ new StoredTabletFile(metadata);
+ } catch (Exception e) {
Review Comment:
We should be able to narrow this down now after @dlmarion changes in #3509.
The parsePath() doesn't throw checked exceptions (just various runtime on
errors like IllegalArgumentException) so I can change this to just
RuntimeException.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
