cshannon commented on PR #3506: URL: https://github.com/apache/accumulo/pull/3506#issuecomment-1614859026
@dlmarion and @ctubbsii - I just pushed up a new commit that adds a static validate method to `StoredTabletFile` so we don't need to construct the `StoredTabletFile` object just to throw it away in `MetadataConstraints`. This (currently) performs the same validation as inside the `StoredTabletFile` constructor, but the downside is that it is possible for the validation here to get out of sync with the constructor sync it's different code paths if someone only changed the constructor or the validate method. The constructor can't really use the validate method without more refactoring or we'd end up parsing the path twice. So I don't know if this is ideal or if we should just keeping the previous change of just constructing the new `StoredTabletFile` object for validation so we always ensure we go through one code path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
