dlmarion commented on code in PR #3542:
URL: https://github.com/apache/accumulo/pull/3542#discussion_r1243610488
##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -1101,7 +1107,7 @@ public void run() {
log.error("Error initializing metrics, metrics will not be emitted.",
e1);
}
- recoveryManager = new RecoveryManager(this,
TIME_TO_CACHE_RECOVERY_WAL_EXISTENCE);
+ recoveryManager = new RecoveryManager(this,
timeToCacheRecoveryWalExistence);
Review Comment:
I'm not sure that makes sense here. This is done during Manager startup
before clients can connect to it. The RecoveryManager is created and the value
of `timeToCacheRecoveryWalExistence` is used in the RecoveryManager constructor
to set the expiration time on the Caffeine CacheBuilder. This is only called
once, not in a loop, and I don't think the Caffeine cache can be updated after
construction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
