ctubbsii commented on code in PR #3542:
URL: https://github.com/apache/accumulo/pull/3542#discussion_r1245765894
##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -449,6 +447,12 @@ public static void main(String[] args) throws Exception {
log.info("SASL is not enabled, delegation tokens will not be available");
delegationTokensAvailable = false;
}
+ this.timeToCacheRecoveryWalExistence =
+
aconf.getTimeInMillis(Property.MANAGER_RECOVERY_WAL_EXISTENCE_CACHE_TIME);
+ }
+
+ public long getWaitTimeBetweenScans() {
+ return
this.getConfiguration().getTimeInMillis(Property.MANAGER_TABLET_GROUP_WATCHER_INTERVAL);
Review Comment:
Since this is now only used once, and the implementation is trivial, this
should now be inline'd, rather than add a new API method to Manager.
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -311,6 +311,13 @@ public enum Property {
"The balancer class that accumulo will use to make tablet assignment and
"
+ "migration decisions.",
"1.3.5"),
+ MANAGER_TABLET_GROUP_WATCHER_INTERVAL("manager.tablet.watcher.interval",
"60s",
+ PropertyType.TIMEDURATION,
+ "Time to wait between scanning tablet states to identify tablets that
need to be assigned, un-assigned, migrated, etc.",
+ "2.1.2"),
+ MANAGER_RECOVERY_WAL_EXISTENCE_CACHE_TIME("manager.recovery.wal.cache.time",
"15s",
+ PropertyType.TIMEDURATION,
+ "Amount of time that the existence of recovery write-ahead logs is
cached.", "2.1.2"),
Review Comment:
This should be grouped adjacent to the other `manager.recovery.*` property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
