keith-turner commented on code in PR #3496:
URL: https://github.com/apache/accumulo/pull/3496#discussion_r1244102217
##########
core/src/main/java/org/apache/accumulo/core/spi/balancer/TableLoadBalancer.java:
##########
@@ -106,6 +123,41 @@ protected TabletBalancer getBalancerForTable(TableId
tableId) {
return balancer;
}
+ private SortedMap<TabletServerId,TServerStatus> getCurrentSetForTable(
+ SortedMap<TabletServerId,TServerStatus> allTServers,
+ Map<String,Set<TabletServerId>> groupedTServers, String resourceGroup) {
+
+ String groupName =
Review Comment:
I don't think we should throw an exception when there are zero tablet
servers, this could be temporary situation that happens normally. Maybe log a
warning and do nothing.
Also I don't think we should fall back to some default when a user
configured group has no tservers in it, could log a warning and take no action.
If a user configured a group and it currently has nothing in it, then we
should wait until it does. This makes the behavior more predictable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
