keith-turner commented on code in PR #3496:
URL: https://github.com/apache/accumulo/pull/3496#discussion_r1244086231
##########
server/base/src/main/java/org/apache/accumulo/server/manager/LiveTServerSet.java:
##########
@@ -393,6 +404,12 @@ public synchronized Set<TServerInstance>
getCurrentServers() {
return new HashSet<>(currentInstances.keySet());
}
+ public synchronized Map<String,Set<TServerInstance>>
getCurrentServersGroups() {
+ Map<String,Set<TServerInstance>> copy = new HashMap<>();
Review Comment:
Its possible that depending on the usage patterns that it may be more
efficient to compute an immutable map of this info when it changes. The
tserver does this for online tablets in
https://github.com/apache/accumulo/blob/main/server/tserver/src/main/java/org/apache/accumulo/tserver/OnlineTablets.java
I don't know if this would be useful w/o analyzing the larger way in which
this is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
