keith-turner commented on code in PR #3582:
URL: https://github.com/apache/accumulo/pull/3582#discussion_r1259946034
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java:
##########
@@ -978,8 +979,20 @@ synchronized void completeClose(boolean saveState, boolean
completeClose) throws
activeScan.interrupt();
}
+ long lastLogTime = System.nanoTime();
+
// wait for reads and writes to complete
while (writesInProgress > 0 || !activeScans.isEmpty()) {
+
+ if (log.isDebugEnabled()
+ && System.nanoTime() - lastLogTime >
Duration.ofSeconds(60).toNanos()) {
Review Comment:
Updated in 65193af to use TimeUnit and I think that looks good. I did not
do the static import for two reasons. First the if stmt was shortened using
TimeUnit and fit on a single line w/o doing the static import. Second its the
only use of TimeUnit.SECONDS in the class, so did not want to add a static
import for a single use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
