DomGarguilo commented on code in PR #3582:
URL: https://github.com/apache/accumulo/pull/3582#discussion_r1260091082
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanDataSource.java:
##########
@@ -286,4 +286,22 @@ public void setInterruptFlag(AtomicBoolean flag) {
throw new UnsupportedOperationException();
}
+ @Override
+ public String toString() {
+ StringBuilder sb = new StringBuilder();
+ sb.append("isNull(memIters):");
+ sb.append(memIters == null);
+ sb.append(" isNull(fileManager):");
+ sb.append(fileManager == null);
+ sb.append(" fileReservationId:");
+ sb.append(fileReservationId);
+ sb.append(" interruptFlag:");
+ sb.append(interruptFlag.get());
+ sb.append(" expectedDeletionCount:");
+ sb.append(expectedDeletionCount);
+ sb.append(" scanParams=[");
+ sb.append(scanParams);
+ sb.append("]");
+ return sb.toString();
+ }
Review Comment:
```suggestion
@Override
public String toString() {
return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE)
.append("isNull(memIters)", memIters == null)
.append("isNull(fileManager)", fileManager == null)
.append("fileReservationId", fileReservationId)
.append("interruptFlag", interruptFlag.get())
.append("expectedDeletionCount", expectedDeletionCount)
.append("scanParams", scanParams)
.toString();
}
```
Not a huge difference, but could explore the use of `ToStringBuilder` to
clean things up here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
