dlmarion commented on code in PR #3621:
URL: https://github.com/apache/accumulo/pull/3621#discussion_r1265551492
##########
core/src/main/java/org/apache/accumulo/core/metadata/StoredTabletFile.java:
##########
@@ -215,14 +198,9 @@ public static String serialize(String path) {
}
public static String serialize(String path, Range range) {
+ requireRowRange(range);
Review Comment:
`errorprone` comment here too
##########
core/src/main/java/org/apache/accumulo/core/metadata/StoredTabletFile.java:
##########
@@ -151,7 +150,11 @@ public String toString() {
* Validates that the provided metadata string for the StoredTabletFile is
valid.
*/
public static void validate(String metadataEntry) {
+ final TabletFileCq tabletFileCq = deserialize(metadataEntry);
+ // Validate the path
ReferencedTabletFile.parsePath(deserialize(metadataEntry).path);
+ // Validate the range
+ requireRowRange(tabletFileCq.range);
Review Comment:
`errorprone` might complain that you are not using the return value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
