cshannon commented on code in PR #3621:
URL: https://github.com/apache/accumulo/pull/3621#discussion_r1267941334
##########
core/src/main/java/org/apache/accumulo/core/metadata/StoredTabletFile.java:
##########
@@ -151,7 +150,11 @@ public String toString() {
* Validates that the provided metadata string for the StoredTabletFile is
valid.
*/
public static void validate(String metadataEntry) {
+ final TabletFileCq tabletFileCq = deserialize(metadataEntry);
+ // Validate the path
ReferencedTabletFile.parsePath(deserialize(metadataEntry).path);
+ // Validate the range
+ requireRowRange(tabletFileCq.range);
Review Comment:
I went ahead and merged this but I like your idea of moving it to a unit
test. If we can guarantee that the construction of the TabletFileFq will always
be valid with testing then we could remove the check. I'll create a follow on
issue to add some tests for this and then I can remove this validation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
