keith-turner commented on code in PR #3583:
URL: https://github.com/apache/accumulo/pull/3583#discussion_r1265671861
##########
server/manager/src/main/java/org/apache/accumulo/manager/compaction/coordinator/CompactionCoordinator.java:
##########
@@ -152,6 +156,9 @@ public class CompactionCoordinator implements
CompactionCoordinatorService.Iface
private static final Cache<ExternalCompactionId,RunningCompaction> COMPLETED
=
Caffeine.newBuilder().maximumSize(200).expireAfterWrite(10,
TimeUnit.MINUTES).build();
+ private static final Cache<Path,Integer> CHECKED_TABLET_DIRS =
+ Caffeine.newBuilder().maximumSize(1000).build();
Review Comment:
> So, with the Weigher you don't get eviction based on recency. It just
starts evicting entries when it's over the size limit.
What documentation where you looking at? I found [these
docs](https://github.com/ben-manes/caffeine/wiki/Eviction#size-based) which
seem to indicate when cache is over size it evicts based on how recently used
it was.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
