keith-turner commented on code in PR #3583:
URL: https://github.com/apache/accumulo/pull/3583#discussion_r1267313633
##########
server/manager/src/main/java/org/apache/accumulo/manager/compaction/coordinator/CompactionCoordinator.java:
##########
@@ -152,6 +156,9 @@ public class CompactionCoordinator implements
CompactionCoordinatorService.Iface
private static final Cache<ExternalCompactionId,RunningCompaction> COMPLETED
=
Caffeine.newBuilder().maximumSize(200).expireAfterWrite(10,
TimeUnit.MINUTES).build();
+ private static final Cache<Path,Integer> CHECKED_TABLET_DIRS =
Review Comment:
If there is no need for it to be static, then making it an instance var
feels a bit cleaner. Making it an instance variable makes less assumptions
about how other code uses the class and it makes some test easier to implement
(like mocking or overriding the cache in unit test).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
