dlmarion commented on code in PR #3677:
URL: https://github.com/apache/accumulo/pull/3677#discussion_r1283497937
##########
server/base/src/main/java/org/apache/accumulo/server/conf/TableConfiguration.java:
##########
@@ -178,6 +178,14 @@ private static CompactionDispatcher
createCompactionDispatcher(AccumuloConfigura
CompactionDispatcher newDispatcher =
Property.createTableInstanceFromPropertyName(conf,
Property.TABLE_COMPACTION_DISPATCHER, CompactionDispatcher.class,
null);
+ if (newDispatcher == null) {
+ // return early to prevent NPE
+ log.error(
Review Comment:
In the case where an invalid classloader context is set, then
`Property.createTableInstanceFromPropertyName` cannot even return the *default*
CompactionDispatcher specified in `Property.TABLE_COMPACTION_DISPATCHER`. This
being null is a symptom of a misconfiguration of the context class loader. I
think it's correct to point out the error here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
