dlmarion commented on code in PR #3677:
URL: https://github.com/apache/accumulo/pull/3677#discussion_r1289961638


##########
server/base/src/main/java/org/apache/accumulo/server/conf/TableConfiguration.java:
##########
@@ -178,6 +178,14 @@ private static CompactionDispatcher 
createCompactionDispatcher(AccumuloConfigura
     CompactionDispatcher newDispatcher = 
Property.createTableInstanceFromPropertyName(conf,
         Property.TABLE_COMPACTION_DISPATCHER, CompactionDispatcher.class, 
null);
 
+    if (newDispatcher == null) {
+      // return early to prevent NPE
+      log.error(

Review Comment:
   Before this change the log file was getting peppered with NPE stack traces 
from below. This change was to make a single line log entry. I can't tell if 
you are making a suggestion with your comment on changing the log level or 
removing this, or just stating that the user should be able to find the 
information in the log as suggested in this log entry.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to