cshannon commented on code in PR #3640:
URL: https://github.com/apache/accumulo/pull/3640#discussion_r1295226065
##########
server/base/src/test/java/org/apache/accumulo/server/manager/state/MergeInfoTest.java:
##########
@@ -213,14 +214,14 @@ public void testNeedsToBeChopped() {
assertFalse(info.needsToBeChopped(ke("y", "c", "b")));
assertFalse(info.needsToBeChopped(ke("x", "c", "bb")));
assertFalse(info.needsToBeChopped(ke("x", "b", "a")));
- info = new MergeInfo(ke("x", "b", "a"), MergeInfo.Operation.MERGE);
- assertTrue(info.needsToBeChopped(ke("x", "c", "a")));
- assertTrue(info.needsToBeChopped(ke("x", "aa", "a")));
- assertTrue(info.needsToBeChopped(ke("x", null, null)));
- assertFalse(info.needsToBeChopped(ke("x", "c", "b")));
- assertFalse(info.needsToBeChopped(ke("y", "c", "b")));
- assertFalse(info.needsToBeChopped(ke("x", "c", "bb")));
- assertTrue(info.needsToBeChopped(ke("x", "b", "a")));
+ // info = new MergeInfo(ke("x", "b", "a"), MergeInfo.Operation.MERGE);
+ // assertTrue(info.needsToBeChopped(ke("x", "c", "a")));
+ // assertTrue(info.needsToBeChopped(ke("x", "aa", "a")));
+ // assertTrue(info.needsToBeChopped(ke("x", null, null)));
+ // assertFalse(info.needsToBeChopped(ke("x", "c", "b")));
+ // assertFalse(info.needsToBeChopped(ke("y", "c", "b")));
+ // assertFalse(info.needsToBeChopped(ke("x", "c", "bb")));
+ // assertTrue(info.needsToBeChopped(ke("x", "b", "a")));
Review Comment:
I can go back when I get a chance and re-visit the tests and see if stuff
still needs to be commented out. It has been a while since I first looked at it
and I don't remember if it is still necessary or why I commented out some of
the tests but I can document why the change if it's needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
