cshannon commented on PR #3640: URL: https://github.com/apache/accumulo/pull/3640#issuecomment-1682910378
@keith-turner - I had 2 questions about this that I figured you might be able to help answer when reviewing since the TabletGroupWatcher class and Manager code in general is pretty new to me still. 1. My current PR currently figures out the previous tablet to figure out row boundaries for fencing by iterating and just tracking things as we iterate. I was thinking it could be better to use the prev row column instead since that is already tracked there but that but since it sorts last I didn't use it as I don't think we could read or see it before seeing the file metadata columns that would need to know the information but wanted to get your thoughts on that. 2. I'm still a bit new to the Manager and how the TabletGroupWatcher is processing changes so I'm not 100% sure yet on the consistency guarantees with the system. The manager is doing the metadata updates for the merge inside of TabletGroupWatcher and I am wondering is it possible for the table or tablets being modified to be split concurrently during the merge or compactions to happen? I am just curious if anything else would interfere and cause a race condition that would invalidate while iterating and merging the metadata. Or do the metadata changes from other events (like splits) get processed in order since the TabletGroupWatcher has a thread that processes events off a queue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
