ctubbsii commented on code in PR #398:
URL: https://github.com/apache/accumulo-website/pull/398#discussion_r1309069530
##########
css/accumulo.scss:
##########
@@ -58,10 +58,6 @@ code {
padding-left: 10px;
}
Review Comment:
If there's any opportunity to remove unnecessary customizations in this
file, or in other css files, using the default bootstrap ones, that would be
nice.
But, there's a lot of customizations in here that I think are broken right
now, because of the class renames or using different header elements for the
section headers (like a div with a class instead of h4, for example).
##########
pages/contact-us.md:
##########
@@ -45,10 +45,10 @@ follow discussions as they happen.
{: .table }
| Name | Description | Read
| Follow | Post |
|-------------------|--------------------------------------------------|------|--------|------|
-| **user** | General user questions, help, and announcements |
[<span class="glyphicon glyphicon-search"/> Archive][U_A] | [<span
class="glyphicon glyphicon-plus"/> Subscribe][U_SU] [<span class="glyphicon
glyphicon-remove"/> Unsubscribe][U_UN] | [<span class="glyphicon
glyphicon-envelope"/> Post][U_P] |
-| **dev** | Contributor discussions and development activity |
[<span class="glyphicon glyphicon-search"/> Archive][D_A] | [<span
class="glyphicon glyphicon-plus"/> Subscribe][D_SU] [<span class="glyphicon
glyphicon-remove"/> Unsubscribe][D_UN] | [<span class="glyphicon
glyphicon-envelope"/> Post][D_P] |
-| **commits** | Code changes |
[<span class="glyphicon glyphicon-search"/> Archive][C_A] | [<span
class="glyphicon glyphicon-plus"/> Subscribe][C_SU] [<span class="glyphicon
glyphicon-remove"/> Unsubscribe][C_UN] | |
-| **notifications** | Automated notifications (GitHub, etc.) |
[<span class="glyphicon glyphicon-search"/> Archive][N_A] | [<span
class="glyphicon glyphicon-plus"/> Subscribe][N_SU] [<span class="glyphicon
glyphicon-remove"/> Unsubscribe][N_UN] | |
+| **user** | General user questions, help, and announcements | [<i
class="fa-solid fa-magnifying-glass"></i> Archive][U_A] | [<i class="fa-solid
fa-plus"></i> Subscribe][U_SU] [<i class="fa-solid fa-xmark"></i>
Unsubscribe][U_UN] | [<i class="fa-solid fa-envelope"></i> Post][U_P] |
Review Comment:
Why switch to `<i>` instead of `<span>`? If we're not actually italicizing
something, `<span>` should suffice as an arbitrary inline element (that's its
sole purpose for existing, just like `<div>`'s sole purpose is as an arbitrary
block element).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
