cshannon commented on code in PR #3830:
URL: https://github.com/apache/accumulo/pull/3830#discussion_r1356911623
##########
server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java:
##########
@@ -544,10 +543,10 @@ public static <T extends TabletFile>
WritableComparable<Key> findLastKey(ServerC
continue;
}
- Key key = reader.getLastKey();
+ Text row = reader.getLastRow();
- if (lastKey == null || key.compareTo(lastKey) > 0) {
- lastKey = key;
+ if (lastRow == null || row.compareTo(lastRow) > 0) {
Review Comment:
I agree, I think the fix here is to add the null check for getFirstRow() and
getLastRow() and then look into if/when the rows would actually be null in
another issue since this is an existing problem and unrelated to the PR here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
