keith-turner commented on code in PR #3830:
URL: https://github.com/apache/accumulo/pull/3830#discussion_r1358950002
##########
core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java:
##########
@@ -1617,20 +1618,20 @@ public Value getTopValue() {
}
@Override
- public Key getFirstKey() throws IOException {
- var rfk = reader.getFirstKey();
- if (fence.beforeStartKey(rfk)) {
- return fencedStartKey;
+ public Text getFirstRow() throws IOException {
+ var rfk = reader.getFirstRow();
+ if (rfk != null && fence.beforeStartKey(new Key(rfk))) {
+ return fencedStartKey.getRow();
} else {
return rfk;
}
}
@Override
- public Key getLastKey() throws IOException {
- var rlk = reader.getLastKey();
- if (fence.afterEndKey(rlk)) {
- return fencedEndKey.get();
+ public Text getLastRow() throws IOException {
+ var rlk = reader.getLastRow();
Review Comment:
could change the var name if the `k` was for key
##########
core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java:
##########
@@ -1617,20 +1618,20 @@ public Value getTopValue() {
}
@Override
- public Key getFirstKey() throws IOException {
- var rfk = reader.getFirstKey();
- if (fence.beforeStartKey(rfk)) {
- return fencedStartKey;
+ public Text getFirstRow() throws IOException {
+ var rfk = reader.getFirstRow();
Review Comment:
could change the var name, assuming the `k` was for key?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
