ddanielr commented on code in PR #3927:
URL: https://github.com/apache/accumulo/pull/3927#discussion_r1386898034
##########
core/src/test/java/org/apache/accumulo/core/conf/PropertyTest.java:
##########
@@ -105,6 +107,35 @@ public void testPorts() {
}
}
+ @Test
+ public void testJson() {
+
assertFalse(TSERV_COMPACTION_SERVICE_META_EXECUTORS.getType().isValidFormat("notJson"));
+
+ // use "real" example
+ String json1 =
+
"[{'name':'small','type':'internal','maxSize':'32M','numThreads':2},{'name':'huge','type':'internal','numThreads':2}]"
+ .replaceAll("'", "\"");
+ // use synthetic, but valid json
+ String json2 =
Review Comment:
If you want to have two separate json test values, we might want to remove
the top level list brackets on one of these so the test values are different
forms of valid json.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
