ddanielr commented on code in PR #3927:
URL: https://github.com/apache/accumulo/pull/3927#discussion_r1386904527
##########
core/src/test/java/org/apache/accumulo/core/conf/PropertyTest.java:
##########
@@ -105,6 +106,20 @@ public void testPorts() {
}
}
+ @Test
+ public void testJson() {
+ // JsonParser.parseString("not json");
+
+ var p1 = TSERV_COMPACTION_SERVICE_META_EXECUTORS;
+
assertFalse(TSERV_COMPACTION_SERVICE_META_EXECUTORS.getType().isValidFormat("notJson"));
+
+ String json =
+
"[{'name':'small','type':'internal','maxSize':'32M','numThreads':2},{'name':'huge','type':'internal','numThreads':2}]"
+ .replaceAll("'", "\"");
+ assertTrue(Property.isValidProperty(p1.getKey(), json));
+
+ }
+
Review Comment:
Changes look good. There's two separate follow up comments on your changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
