keith-turner commented on code in PR #3915:
URL: https://github.com/apache/accumulo/pull/3915#discussion_r1391451647
##########
core/src/main/java/org/apache/accumulo/core/spi/compaction/DefaultCompactionPlanner.java:
##########
@@ -146,15 +172,25 @@ public String toString() {
justification = "Field is written by Gson")
@Override
public void init(InitParameters params) {
- ExecutorConfig[] execConfigs =
- GSON.get().fromJson(params.getOptions().get("executors"),
ExecutorConfig[].class);
-
List<Executor> tmpExec = new ArrayList<>();
+ ExecutorConfig[] execConfigs = null;
+ QueueConfig[] queueConfigs = null;
+
Review Comment:
> I want to ensure that the user is able to define internal compactions via
the executors option and also add external compactors via queues. Would making
these mutually exclusive break that functionality?
I did not realize that was goal, I like that goal and my suggestion would
break that. I was thinking of the case of only using external compactions,
but being able to mix them and transition to the new property seems nice. And
there is handling of same queue name being specified in executors and queues,
which is nice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
