ddanielr commented on code in PR #3915:
URL: https://github.com/apache/accumulo/pull/3915#discussion_r1399794089
##########
core/src/main/java/org/apache/accumulo/core/spi/compaction/DefaultCompactionPlanner.java:
##########
@@ -184,6 +220,32 @@ public void init(InitParameters params) {
tmpExec.add(new Executor(ceid, maxSize));
}
+ values = "";
+ if (params.getOptions().containsKey("queues")) {
+ values = params.getOptions().get("queues");
+ }
+
+ if (!values.isBlank()) {
+ queueConfigs = GSON.get().fromJson(values, QueueConfig[].class);
+ } else {
+ // Generated a zero-length array to avoid a npe thrown by forEach
+ queueConfigs = new QueueConfig[0];
+ }
+
+ for (QueueConfig queueConfig : queueConfigs) {
+ Long maxSize = queueConfig.maxSize == null ? null
+ : ConfigurationTypeHelper.getFixedMemoryAsBytes(queueConfig.maxSize);
+
+ CompactionExecutorId ceid;
+ String queue = Objects.requireNonNull(queueConfig.name, "'name' must be
specified");
+ ceid = params.getExecutorManager().getExternalExecutor(queue);
Review Comment:
Yes, that will be added in the next PR for #3472.
The property stuff seemed complicated enough I wanted to handle the
deprecation in two PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
