ddanielr commented on code in PR #4079:
URL: https://github.com/apache/accumulo/pull/4079#discussion_r1428615177
##########
server/manager/src/main/java/org/apache/accumulo/manager/compaction/queue/CompactionJobPriorityQueue.java:
##########
@@ -158,6 +158,9 @@ public synchronized long getQueuedJobs() {
}
public synchronized long getLowestPriority() {
+ if (jobQueue.isEmpty()) {
Review Comment:
Each queue is registered with the MeterRegistry which calls this method
directly on update.
So the Micrometer code would have to support handling an Optional.
Looking at their docs, I don't see anything popping out about Optionals.
We could certainly write some test cases and see what happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
