keith-turner commented on code in PR #4079:
URL: https://github.com/apache/accumulo/pull/4079#discussion_r1430756432
##########
server/manager/src/main/java/org/apache/accumulo/manager/compaction/queue/CompactionJobPriorityQueue.java:
##########
@@ -158,6 +158,9 @@ public synchronized long getQueuedJobs() {
}
public synchronized long getLowestPriority() {
+ if (jobQueue.isEmpty()) {
Review Comment:
> Looking at their docs, I don't see anything popping out about Optionals.
ok, that makes sense. Then if this method returned an optional then when
its empty we would have to unregister the metrics, which would not be pretty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
