ddanielr commented on PR #4080:
URL: https://github.com/apache/accumulo/pull/4080#issuecomment-1858645531
> @ddanielr I opened #4081 about removing selector compactions. The reason
the test is failing is that selector compactions are not implemented in
elasticity. Looking into this I am thinking we should remove the functionality
rather than implement it.
>
> I modified the test not to wait on the selector compaction and it works.
The user compactions that select files work. If we know we are going to take
the path outlined in #4081 the we could update the test to remove setting the
selector plugin on the table.
>
> ```diff
> diff --git
a/test/src/main/java/org/apache/accumulo/test/compaction/CompactionExecutorIT.java
b/test/src/main/java/org/apache/accumulo/test/compaction/CompactionExecutorIT.java
> index a7309cb693..92c0c0f49f 100644
> ---
a/test/src/main/java/org/apache/accumulo/test/compaction/CompactionExecutorIT.java
> +++
b/test/src/main/java/org/apache/accumulo/test/compaction/CompactionExecutorIT.java
> @@ -358,9 +358,9 @@ public class CompactionExecutorIT extends
SharedMiniClusterBase {
> assertEquals(2, getFiles(client, "tmd_control2").size());
> assertEquals(2, getFiles(client, "tmd_control3").size());
>
> - while (getFiles(client, "tmd_selector").size() != 0) {
> - Thread.sleep(100);
> - }
> + //while (getFiles(client, "tmd_selector").size() != 0) {
> + // Thread.sleep(100);
> + //}
>
> assertEquals(2, getFiles(client, "tmd_control1").size());
> assertEquals(2, getFiles(client, "tmd_control2").size());
> ```
I removed the code for the selector compactions and now all tests are
working.
I think #4081 is the correct way to go since it's moving all of those custom
compaction functions under user control.
If we come to a different decision with #4081 then we could revisit adding
the logic back to this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
