ddanielr commented on PR #4080:
URL: https://github.com/apache/accumulo/pull/4080#issuecomment-1862002939

   > I think this looks good, could maybe simplify the test json as a I made a 
comment about.
   
   I simplified the json and added a runtime exception for the 
stopCompactorGroup test.
    
   > Did you consider moving to having each test method run its own mini 
accumulo instead of stoppping compactors between test?
   
   I did but I decided against that because spinning compaction resources up 
and down against a long-lived cluster is closer to a "real-life" test scenario 
then testing the compaction services in isolation. 
   
   Also, an extra step is required for tests that change the compaction 
resources mid-test for the AccumuloClusterHarness.
   
   You must cast the config in order to access the groups directly and change 
their values.
   
   ```
   MiniAccumuloClusterImpl mini = (MiniAccumuloClusterImpl) getCluster();
   
mini.getConfig().getClusterServerConfiguration().addCompactorResourceGroup("group1",
 4);
   mini.getClusterControl().start(ServerType.COMPACTOR);
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to