keith-turner commented on code in PR #4115:
URL: https://github.com/apache/accumulo/pull/4115#discussion_r1441173711
##########
test/src/main/java/org/apache/accumulo/test/ImportExportIT.java:
##########
@@ -294,6 +295,7 @@ public void testExportImportOffline() throws Exception {
// verify the new table is offline
assertFalse(client.tableOperations().isOnline(destTable), "Table should
have been offline.");
+ assertEquals(getServerContext().getTableState(TableId.of(tableId)),
TableState.OFFLINE);
Review Comment:
Does the following sound correct? Want to make sure I understand these
changes.
* Without these changes the table would be in the new state, so
`client.tableOperations().isOnline(destTable)` would have returned false.
* The call to `client.tableOperations().online(destTable, true)` just kinda
fix things for the rest of the test.
If that is true, it makes me wonder if the call
`client.tableOperations().online(destTable, true)` should be a bit more strict
about what table states it will transition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
