keith-turner commented on code in PR #4115:
URL: https://github.com/apache/accumulo/pull/4115#discussion_r1442371478
##########
test/src/main/java/org/apache/accumulo/test/ImportExportIT.java:
##########
@@ -294,6 +295,7 @@ public void testExportImportOffline() throws Exception {
// verify the new table is offline
assertFalse(client.tableOperations().isOnline(destTable), "Table should
have been offline.");
+ assertEquals(getServerContext().getTableState(TableId.of(tableId)),
TableState.OFFLINE);
Review Comment:
Yeah it can fix things, but it can also hide bugs in other parts of the
code. If it were more strict maybe this bug would have been found sooner. I
think it would be good to make it more strict and leave fixing buggy situations
to something else like zookeeper surgery or a specialized tool if the need
arises frequently enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
