EdColeman commented on code in PR #4148:
URL: https://github.com/apache/accumulo/pull/4148#discussion_r1447637851
##########
server/base/src/main/java/org/apache/accumulo/server/compaction/FileCompactor.java:
##########
@@ -279,7 +287,10 @@ public CompactionStats call() throws IOException,
CompactionCanceledException {
log.debug("Compaction canceled {}", extent);
throw e;
} catch (IOException | RuntimeException e) {
- log.error("{}", e.getMessage(), e);
+ log.error("Compaction error. Compaction info: "
+ + "extent: {}, input files: {}, output file: {}, iterators: {},
start date: {}. Error message: {}",
+ getExtent(), getFileNamesToCompact(), getOutputFileName(),
getIterators(),
+ threadStartDate, e.getMessage(), e);
Review Comment:
Is `e.getMessage()` along with `e` redundant? If the exception is logged
with the stack trace it will include the message as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
