keith-turner commented on code in PR #4148:
URL: https://github.com/apache/accumulo/pull/4148#discussion_r1447693663
##########
server/base/src/main/java/org/apache/accumulo/server/compaction/FileCompactor.java:
##########
@@ -461,6 +472,10 @@ Collection<StoredTabletFile> getFilesToCompact() {
return filesToCompact.keySet();
}
+ Collection<String> getFileNamesToCompact() {
Review Comment:
If this is only used in one place, I would inline it. But that is a style
thing, feel free to ignore the comment.
If not inlined, could make it private.
```suggestion
private Collection<String> getFileNamesToCompact() {
```
##########
server/base/src/main/java/org/apache/accumulo/server/compaction/FileCompactor.java:
##########
@@ -189,6 +191,10 @@ protected String getOutputFile() {
return outputFile.toString();
}
+ protected String getOutputFileName() {
Review Comment:
Why is this protected?
I would inline this if its only used in one place. But that is a style
thing, feel free to ignore the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
