keith-turner commented on code in PR #4136:
URL: https://github.com/apache/accumulo/pull/4136#discussion_r1448015366
##########
core/src/main/java/org/apache/accumulo/core/metadata/schema/MetadataSchema.java:
##########
@@ -433,6 +420,23 @@ public static class HostingColumnFamily {
public static final String REQUESTED_QUAL = "requested";
public static final ColumnFQ REQUESTED_COLUMN = new ColumnFQ(NAME, new
Text(REQUESTED_QUAL));
}
+
+ // These can be removed when the corresponding upgrade code is removed
+ public static class Upgrade12to13 {
Review Comment:
I started with that approach and then in testing I ran into a problem where
the upgrade code could not write to the metadata table because of the metadata
table constraint. So I had to make the constraint code still use these columns
and the package it is in can not access the Upgrader (constraint is in server
or core while Upgrader is in manager jar).
So I ended up settling on this approach of isolating the columns in the
MetadataSchema class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
