keith-turner commented on code in PR #4136:
URL: https://github.com/apache/accumulo/pull/4136#discussion_r1448100287


##########
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/Upgrader12to13.java:
##########
@@ -120,6 +125,7 @@ private void 
removeCompactColumnsFromRootTabletMetadata(ServerContext context) {
           Preconditions.checkState(key.getColumnVisibilityData().length() == 0,
               "Expected empty visibility, saw %s ", 
key.getColumnVisibilityData());
           Mutation m = new Mutation(row);
+          // TODO will metadata contraint fail when this is written?

Review Comment:
   @EdColeman I was going off of memory from doing code reviews and confused 
#3876 with #3963.  @dlmarion do you know if this write that deletes the compact 
col will fail because the metadata constraint does not know about it? Trying to 
determine if I need to open an issue for this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to